[Lldb-commits] [PATCH] D16128: Fix TestProcessLaunch.test_environment_with_special_char for Python 3

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 13 08:26:04 PST 2016

labath added a comment.

In http://reviews.llvm.org/D16128#325814, @labath wrote:

> > There's lots of tests currently that redirect stdio, are those all broken on Linux currently?
> The redirection works on linux, it's just not 100% reliable in tests. The thing is that inferior stdio arrives asynchronously wrt. everything else, so you really cannot be sure that by the time you do GetSTDOUT(), all output will be available. It works most of the time, but it fails in like ~0.1% of cases -- not much, but enough to be annoying when scrutinizing buildbot failures.

Or, if you meant the other kind of redirection, in all tests that redirect stdio to a file, we have added a `if(remote) { platform.GetFile(...)}`, to retrieve the file from the remote side -- not really elegant and I would prefer using the `char[]` approach going forward.


More information about the lldb-commits mailing list