[Lldb-commits] [PATCH] D16128: Fix TestProcessLaunch.test_environment_with_special_char for Python 3

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 13 02:24:01 PST 2016

labath added a subscriber: labath.
labath requested changes to this revision.
labath added a reviewer: labath.
labath added a comment.
This revision now requires changes to proceed.

This will make the test fail on remote platforms, as the redirected file needs to be transferred in before you can check it (see TestQuoting for an example).

It sounds like we should come up with some guidelines wrt. using stdio in tests. I would like to use it as it is much simpler than using files, but I guess supporting that for windows, where you launch the inferior in a separate console window (which i very like btw) could be difficult (?). If we get rid of it, we might even kill two birds with one stone, as we have some stdio issues on linux as well (https://llvm.org/bugs/show_bug.cgi?id=25652). My favourite replacement for that would be inferior sticking whatever output in needs in a char[] variable and debugger reading it from there. This should hopefully work in all scenarios, as it does not depend on any external concepts.

Thoughts ?


More information about the lldb-commits mailing list