[Lldb-commits] [PATCH] D16128: Fix TestProcessLaunch.test_environment_with_special_char for Python 3
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Tue Jan 12 16:29:12 PST 2016
zturner created this revision.
zturner added a reviewer: amccarth.
zturner added a subscriber: lldb-commits.
There were a number of problems preventing this from working:
1. The SWIG typemaps for converting Python lists to and from C++
arrays were not updated for Python 3. So they were doing things
like PyString_Check instead of using the PythonString from
2. ProcessLauncherWindows was ignoring the environment completely.
So any test that involved launching an inferior with any kind
of environment variable would have failed.
3. The test itself was using process.GetSTDOUT(), which isn't
implemented on Windows. So this was changed to redirect
stdout to a file, and then the test reads the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 8928 bytes
Desc: not available
More information about the lldb-commits