[Lldb-commits] [PATCH] D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines.

[Dawn Perchik via lldb-commits]

dawn added a comment.

In http://reviews.llvm.org/D15593#319670, @clayborg wrote:

> ... in the future when adding things for MI, please add an API in the lldb::SB layer to do what you need.


Thanks for not asking me to do that as part of this patch.

> Text scraping is really not the solution we should be adding into the code. Other people using MI are going to see this kind of code and think it is what they should do when implementing/fixing new/existing MI commands.


I agree that MI should have used the SB layer - did anyone ask the authors about that?  Because as you say, the text scraping has now become a precedent for MI commands.

> We have an API for a debugger that we are trying to make with the lldb::SB layer, so we should use it and stop ANY form of text scraping in the future. I think an API'ized version of what you are requesting here -- all line table entries for a given source file -- should be available from SBTarget and a future modification to MICmdCmdSymbol.cpp should switch over to using it.


+100.  Except that I think it should only apply to new code - bug fixes like this shouldn't be held back because of preexisting code.

Rewriting lldb-mi to use the SB layer would be a great project for an intern or someone who wants to get familiar with lldb.  We should keep that in mind if/when folks on lldb-dev ask about how they can help out.


Repository:
  rL LLVM

http://reviews.llvm.org/D15593