[Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries <file>" command and use it to fix MI's -symbol-list-lines.

[Dawn Perchik via lldb-commits]

dawn added a comment.

In http://reviews.llvm.org/D15593#312665, @jingham wrote:

> So it seems like your change is adding three flags
>
>   --compile-unit-only --only-explicit-matches --show-raw
>
> or something.  The current behavior is:
>
>   --compile-unit-only true --only-explicit-matches false --show-raw true 
>
> and your command does:
>
>   --compile-unit-only false --only-explicit-matches true --show-raw false 
>
> Does that seem right.


Yup.

> If so, then we have to decide whether it is worth the effort to be able to tweak these three independently.


I think these flags only make sense if you could tweak them independently, but to support something like:

  --compile-unit-only false --only-explicit-matches true --show-raw *true* 

would be a major pain - it would mean adding a lot of extra code and interfaces for something that would only be used by this one command.

I think it's better to just have both:

  target modules line-tables <cu>
  target modules line-entries <file>

and if we find a need for any other combinations of the options you proposed, we can merge them at that time.

Thoughts?


Repository:
  rL LLVM

http://reviews.llvm.org/D15593