[Lldb-commits] [PATCH] D15533: Make the aarch64 lldb-server capable of debugging arm32 applications

[Tamas Berghammer via lldb-commits]

tberghammer added a comment.

Note: This change is blocked by http://reviews.llvm.org/D15529. If that one will get rejected then we have to move some of the 32 <-> 64 architecture matching code into LLDB.


================
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp:1016
@@ +1015,3 @@
+#else // __aarch64__
+    int regset = NT_PRSTATUS;
+    struct iovec ioVec;
----------------
ovyalov wrote:
> Could you wrap aarch64 code into a static function in NativeRegisterContextLinux_arm64 so it can be reused both here and in NativeRegisterContextLinux_arm64::DoReadGPR?
I don't want to call NativeRegisterContextLinux_arm64::DoReadGPR because conceptually a function on NativeRegisterContextLinux_arm64 should read out arm64 resisters while this one reads out arm32 registers. I changed to code to use NativeRegisterContextLinux::ReadRegisterSet what simplifies it quite a bit.


http://reviews.llvm.org/D15533