[Lldb-commits] [lldb] r255718 - Propagate socket_error exception from handle_read. Otherwise Ninja crashes.

Adrian McCarthy via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 15 15:51:27 PST 2015


Author: amccarth
Date: Tue Dec 15 17:51:27 2015
New Revision: 255718

URL: http://llvm.org/viewvc/llvm-project?rev=255718&view=rev
Log:
Propagate socket_error exception from handle_read.  Otherwise Ninja crashes.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/dotest_channels.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest_channels.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest_channels.py?rev=255718&r1=255717&r2=255718&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/dotest_channels.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest_channels.py Tue Dec 15 17:51:27 2015
@@ -140,13 +140,12 @@ class UnpicklingForwardingReaderChannel(
             print(
                 "\nINFO: received socket error when reading data "
                 "from test inferior:\n{}".format(socket_error))
-            # Should be good to return here.
-            return
+            raise
         except Exception as general_exception:
             print(
                 "\nERROR: received non-socket error when reading data "
                 "from the test inferior:\n{}".format(general_exception))
-            return
+            raise
 
         # Consume the message content.
         while data and (len(data) > 0):




More information about the lldb-commits mailing list