[Lldb-commits] [PATCH] D15428: Make debug info specification use categories system

[Tamas Berghammer via lldb-commits]

tberghammer added inline comments.

================
Comment at: packages/Python/lldbsuite/test/lang/cpp/limit-debug-info/TestWithLimitDebugInfo.py:9
@@ -8,4 +8,3 @@
 
-    @dwarf_test
-    def test_with_dwarf(self):
-        self.buildDwarf()
+    @skipIf(debug_info=not_in(["dwarf"]))
+    def test_limit_debug_info(self):
----------------
Considering your change in lldbtest.py:2227 I think you should annotate the function with add_test_categories(["dwarf"]) instead

================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:2227-2228
@@ +2226,4 @@
+
+                # If any debug info categories were explicitly tagged, assume that list to be
+                # authoritative.  If none were specified, try with all debug info formats.
+                all_dbginfo_categories = set(test_categories.debug_info_categories)
----------------
I think this won't work if the list of debug info formats are specified on class level instead of at function level.


http://reviews.llvm.org/D15428