[Lldb-commits] [PATCH] D15451: Make test categories composable

[Tamas Berghammer via lldb-commits]

tberghammer added inline comments.

================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:518
@@ +517,3 @@
+        if hasattr(func, "categories"):
+            cat.extend(func.categories)
+        func.categories = cat
----------------
tfiala wrote:
> This code could potentially accept a single category and drop the need for the list.  It could check the type of the input (i.e. the categories input) and, if a single element rather than a list, it could just cat.append() it.
> 
> That would enable a single argument passed to @add_test_categories()
> 
> Totally minor and you can skip this, it just makes for a nice usability enhancement provided the decorator is documented as such.
+1: I think we will (accidentally) call the function by a single string in some case so accepting it would be a good idea.


http://reviews.llvm.org/D15451