[Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

[Eugene Zelenko via lldb-commits]

At least clang-format should be applied to all newly added files before commit.

Eugene.

On Fri, Dec 11, 2015 at 2:30 PM, Zachary Turner <zturner at google.com> wrote:
> Back on the topic of clang-format, what would it take to make clang-format a
> regular part of peoples' workflows?
>
> On Fri, Dec 11, 2015 at 2:27 PM Todd Fiala <todd.fiala at gmail.com> wrote:
>>
>> Yep - sorry.  I had been talking to Greg about this and misunderstood his
>> comment on it. My mistake entirely.  Kate and I just talked and she pointed
>> me to your document, Jim.
>>
>> The description was:
>> where we had a clearly adhered to standard, keep it.
>> whee we didn't, we adopted LLVM.
>>
>> Sorry for rehashing!
>>
>> -Todd
>>
>> On Fri, Dec 11, 2015 at 2:12 PM, Jim Ingham <jingham at apple.com> wrote:
>>>
>>>
>>> On Dec 11, 2015, at 2:01 PM, Todd Fiala via lldb-commits
>>> <lldb-commits at lists.llvm.org> wrote:
>>>
>>>
>>>
>>> On Fri, Dec 11, 2015 at 1:59 PM, Zachary Turner <zturner at google.com>
>>> wrote:
>>>>
>>>> On Fri, Dec 11, 2015 at 1:55 PM Todd Fiala via lldb-commits
>>>> <lldb-commits at lists.llvm.org> wrote:
>>>>>
>>>>> Hey Eugene and Greg,
>>>>>
>>>>> I thought we were doing spaces before the open parens in places like
>>>>> this:
>>>>>
>>>>> -    BreakpointResolverSP resolver_sp(new BreakpointResolverFileLine
>>>>> (NULL,
>>>>> ...
>>>>> +    BreakpointResolverSP resolver_sp(new
>>>>> BreakpointResolverFileLine(nullptr,
>>>>>
>>>>> (see the removal of the space after BreakpointResolverFileLine from the
>>>>> clang-tidy settings I presume).
>>>>>
>>>>> Did I misunderstand that?
>>>>
>>>>
>>>> This was officially removed from the coding standard some months ago,
>>>
>>>
>>> Okay.  Are we 100% in sync with LLVM coding standard guidelines?  If so I
>>> can just look there to see what we're supposed to be doing.
>>>
>>>
>>> No, the differences between the lldb and llvm coding standards are
>>> documented in:
>>>
>>> http://lldb.llvm.org/lldb-coding-conventions.html
>>>
>>> Jim
>>>
>>>
>>>>
>>>> but not everyone has adopted this unfortunately.  See r228860.  It pains
>>>> me to no end that we differ from LLVM, because it leads to exactly these
>>>> type of problems where people aren't sure what the exact set of rules are.
>>>
>>>
>>>
>>>
>>> --
>>> -Todd
>>> _______________________________________________
>>> lldb-commits mailing list
>>> lldb-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>>>
>>>
>>
>>
>>
>> --
>> -Todd