[Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

[Zachary Turner via lldb-commits]

On Fri, Dec 11, 2015 at 1:55 PM Todd Fiala via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> Hey Eugene and Greg,
>
> I thought we were doing spaces before the open parens in places like this:
>
> -    BreakpointResolverSP resolver_sp(new BreakpointResolverFileLine (NULL,
> ...
> +    BreakpointResolverSP resolver_sp(new BreakpointResolverFileLine(
> nullptr,
>
> (see the removal of the space after BreakpointResolverFileLine from the
> clang-tidy settings I presume).
>
> Did I misunderstand that?
>

This was officially removed from the coding standard some months ago, but
not everyone has adopted this unfortunately.  See r228860.  It pains me to
no end that we differ from LLVM, because it leads to exactly these type of
problems where people aren't sure what the exact set of rules are.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151211/f0ae3288/attachment.html>