[Lldb-commits] [PATCH] D15435: Add tests to inspect a stack and local variables from a mini dump

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 10 16:06:22 PST 2015


zturner added a comment.

Would it make sense to check in a minidump?  I agree we should have at least one test somewhere that creates a minidump and loads it up and verifies it can do something.  But by making every minidump test use that same flow, then if that first test ever fails for whatever reason, every other test is automatically guaranteed to fail.  Seems like it would be better to test the minimum amount of functionality possible, which in this case would mean removing the step that creates the minidump.


http://reviews.llvm.org/D15435





More information about the lldb-commits mailing list