[Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

[Greg Clayton via lldb-commits]

I like the clang specific patch here better. Mainly because if you add a function like this to TypeSystem.h:

    virtual uint32_t
    DeclContextCountDeclLevels (void *opaque_decl_ctx,
                                void *opaque_find_decl_ctx,
                                ConstString *find_name = nullptr,
                                CompilerType *find_type = nullptr) = 0;


It means that you will have a function in the CompilerDeclContext named "CountDeclLevels(...)". The "DeclContext" prefix is the convention in TypeSystem.h that says "I will add a corresponding function to CompilerDeclContext that will call through to this function.

I still like the clang specific version better because I still think it doesn't make a sensible API for CompilerDeclContext.

Greg

> On Dec 9, 2015, at 9:19 PM, Dawn Perchik <dawn+llvm at burble.org> wrote:
> 
> dawn updated this revision to Diff 42375.
> dawn added a comment.
> 
> This version of the patch makes the API specific to clang.
> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D15312
> 
> Files:
>  include/lldb/Symbol/ClangASTContext.h
>  packages/Python/lldbsuite/test/lang/cpp/namespace/Makefile
>  packages/Python/lldbsuite/test/lang/cpp/namespace/main.cpp
>  packages/Python/lldbsuite/test/lang/cpp/namespace/ns.cpp
>  packages/Python/lldbsuite/test/lang/cpp/namespace/ns.h
>  packages/Python/lldbsuite/test/lang/cpp/namespace/ns2.cpp
>  packages/Python/lldbsuite/test/lang/cpp/namespace/ns3.cpp
>  source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
>  source/Symbol/ClangASTContext.cpp
> 
> <D15312.42375.patch>