[Lldb-commits] [lldb] r255150 - Delete the -F command line option from dotest.py.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Wed Dec 9 12:48:20 PST 2015


Author: zturner
Date: Wed Dec  9 14:48:19 2015
New Revision: 255150

URL: http://llvm.org/viewvc/llvm-project?rev=255150&view=rev
Log:
Delete the -F command line option from dotest.py.

This removes the failfast command line option as part of an effort
to simplify dotest and remove unused command line options.  You can
still Ctrl+C any time you want to exit early.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/configuration.py
    lldb/trunk/packages/Python/lldbsuite/test/dotest.py
    lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/configuration.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/configuration.py?rev=255150&r1=255149&r2=255150&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/configuration.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/configuration.py Wed Dec  9 14:48:19 2015
@@ -91,9 +91,6 @@ bmBreakpointSpec = None
 # The benchmark iteration count, as specified by the '-y' option.
 bmIterationCount = -1
 
-# By default, failfast is False.  Use '-F' to overwrite it.
-failfast = False
-
 # The filters (testclass.testmethod) used to admit tests into our test suite.
 filters = []
 

Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest.py?rev=255150&r1=255149&r2=255150&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/dotest.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest.py Wed Dec  9 14:48:19 2015
@@ -305,9 +305,6 @@ def parseOptionsAndInitTestdirs():
         sys.stdout.flush()
         os.kill(os.getpid(), signal.SIGSTOP)
 
-    if args.F:
-        configuration.failfast = True
-
     if args.f:
         if any([x.startswith('-') for x in args.f]):
             usage(parser)
@@ -1265,7 +1262,6 @@ def run_suite():
             if configuration.count == 1:
                 result = unittest2.TextTestRunner(stream=sys.stderr,
                                                   verbosity=v,
-                                                  failfast=configuration.failfast,
                                                   resultclass=test_result.LLDBTestResult).run(configuration.suite)
             else:
                 # We are invoking the same test suite more than once.  In this case,
@@ -1276,7 +1272,6 @@ def run_suite():
                
                     result = unittest2.TextTestRunner(stream=sys.stderr,
                                                       verbosity=v,
-                                                      failfast=configuration.failfast,
                                                       resultclass=test_result.LLDBTestResult).run(configuration.suite)
 
             configuration.failed = configuration.failed or not result.wasSuccessful()

Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py?rev=255150&r1=255149&r2=255150&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py Wed Dec  9 14:48:19 2015
@@ -88,7 +88,6 @@ def create_parser():
     # Test-suite behaviour
     group = parser.add_argument_group('Runtime behaviour options')
     X('-d', 'Suspend the process after launch to wait indefinitely for a debugger to attach')
-    X('-F', 'Fail fast. Stop the test suite on the first error/failure')
     X('-i', "Ignore (don't bailout) if 'lldb.py' module cannot be located in the build tree relative to this script; use PYTHONPATH to locate the module")
     X('-n', "Don't print the headers like build dir, lldb version, and svn info at all")
     X('-P', "Use the graphic progress bar.")




More information about the lldb-commits mailing list