[Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 8 09:37:02 PST 2015


clayborg added a comment.

So one thing I don't want to propagate here is the "go parse everything inside a decl context" if we can avoid it. I believe the first CompilerDeclContext patch did this, but I don't remember the exact details so I could be wrong. But going forward I would like to see more of "find a struct named 'X' in CompilerDeclContext 'Y'" queries, instead of "parse everything in CompilerDeclContext 'Y' and then I would look for 'X'". Or if we know what we are looking for (function decl contexts and lexical block decl contexts in this case), then I would prefer to have "go parse all function and block decl contexts in CompilerDeclContext 'Y'".


Repository:
  rL LLVM

http://reviews.llvm.org/D15312





More information about the lldb-commits mailing list