[Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

[Ed Maste via lldb-commits]

emaste added inline comments.

================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:832-834
@@ -828,2 +831,5 @@
 
+def expectedFlakeyNetBSD(bugnumber=None, compilers=None):
+    return expectedFlakeyOS(['netbsd'], bugnumber, compilers)
+
 def expectedFlakeyLinux(bugnumber=None, compilers=None):
----------------
perhaps put after FlakeyLinux so we only have to move FreeBSD to put it in alpha order

================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:2292-2293
@@ -2273,2 +2291,4 @@
             return ['libc++.so.1']
+        elif self.getPlatform() == 'netbsd':
+            return ['libstdc++.so']
         else:
----------------
This seems wrong; if a test needs libc++ it should either be skipped on NetBSD right now or use libc++


Repository:
  rL LLVM

http://reviews.llvm.org/D15262