[Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 4 12:52:04 PST 2015

jingham added a comment.

The logic was:

- Set a breakpoint on some loop that will get hit multiple times in some thread worker function.
- The first time it is hit, make it specific to the thread that hit it by setting a Thread ID on the breakpoint.
- Then add a condition to the breakpoint that all the other threads will pass, but the thread that matches the thread specification will fail.
- Then continue, and there should be no more breakpoint hits.

So the original test really tested that the combinations "breakpoint thread ID doesn't pass, but condition does" and "breakpoint thread ID passes, but breakpoint condition doesn't" work properly.

Making sure such combinations function as expected seems like a good thing to test, so I don't think we should remove this test.

But it would also be good to have a test JUST on the thread specification.  So I'd be happy to have this as an extra test.


More information about the lldb-commits mailing list