[Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

[Zachary Turner via lldb-commits]

zturner created this revision.
zturner added reviewers: jingham, labath.
zturner added a subscriber: lldb-commits.

    This test would fail before if conditional breakpoints weren't
    working correctly, and the nature of the test (spinning up 10
    threads, etc) opens the door to raciness.

    This patch vastly simplifies the test, removes the need for relying
    on conditional expression evaluation, and as a result makes the
    correctness of the test vastly easier to reason about and reduces
    flakiness.

    This test also used to pass on Windows only when the inferior was
    compiled with a specific version of MSVC, even though I could verify
    from inside of LLDB that thread-specific breakpoints don't work.  With
    this patch, the test now correctly fails no matter what version of MSVC
    the inferior was compiled with.

Jim: Since the test still fails for me even after this patch, can you verify that
it does not regress anything on OSX?  I think it's a better test overall, so as
long as it doesn't regress anything anywhere I think it should probably go in.

http://reviews.llvm.org/D15241

Files:
  packages/Python/lldbsuite/test/functionalities/thread/thread_specific_break/TestThreadSpecificBreakpoint.py
  packages/Python/lldbsuite/test/functionalities/thread/thread_specific_break/main.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15241.41908.patch
Type: text/x-patch
Size: 6205 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151204/fbb52bc4/attachment.bin>