[Lldb-commits] [PATCH] D15175: Fix breakpoint language filtering for other C variants (like C99) and Pascal.

Dawn Perchik via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 3 21:16:45 PST 2015

dawn added a comment.

Jim, this patch doesn't attempt to fix the issue I raised in my comment - it just fixes the oversight of other C variants (clang picks C99 for example) and renames your function to a more meaningful name (and matches Mangled::GuessLanguage which is also uses the name to guess the language).  I see no reason why to reject it.

I didn't want to try and tackle the bigger problem in this patch, but wanted to raise the question so I might know how to resolve it in a different patch.

Thank you for the feedback however - I like your "Any" suggestion and will submit another patch for it.

Please accept this patch?



More information about the lldb-commits mailing list