[Lldb-commits] [PATCH] D15152: Change Platform::LoadImage to copy the file to the remote platform

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 3 10:07:43 PST 2015

clayborg added a comment.

Be sure to add nice HeaderDoc to the LoadImage() declaration in Platform.h so everyone knows what is expected. We still might want to split this up so that only Platform has LoadImage and we make everyone else just implement:

  virtual uint32_t DoLoadImage(lldb_private::Process* process, const FileSpec& image_spec, Error& error);

These functions would _only_ load the native "image_spec", but the Platform::LoadImage() would take care of all of the common code that checks the two FileSpec parameters and installs the stuff if needed, then calls through to the DoLoadImage() in subclasses.

How does that sound?


More information about the lldb-commits mailing list