[Lldb-commits] [PATCH] D15152: Change Platform::LoadImage to copy the file to the remote platform

[Tamas Berghammer via lldb-commits]

tberghammer added a comment.

I would like to exposed the ability to specify if we want the specified file to be copied over to the target or not both at the command line and on the SB API. To do this without duplicating the logic what do the file installation into CommandObjectProcess and SBProcess I think we have to keep the logic inside the Platform plugin and then we should change the signature of Platform::LoadImage.

One possible solution what can cover all scenario is the following syntax

  LoadImage(Process* process, const FileSpec& local_file, const FileSpec& remote_file)

with the following meaning:

- If both file spec is specified then we copy over the file to the target
- If only the remote file is specified then we open the specified file from the target
- If only the local file is specified the we copy the file over to the current working directory and open it from there


http://reviews.llvm.org/D15152