[Lldb-commits] [PATCH] D15187: Improve the functionality of JSONNumber

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 3 09:34:17 PST 2015

clayborg added a comment.

Everything looks good, just wondering why we need the template code? See inlined comments.

Comment at: include/lldb/Utility/JSON.h:102-104
@@ +101,5 @@
+        template <typename T,
+                  typename std::enable_if<std::is_integral<T>{} &&
+                                          std::is_unsigned<T>{}>::type* = nullptr>
+        explicit JSONNumber (T u) :
What value is the template code giving us? Why can't we omit this and just have a constructor with int64_t and double?


More information about the lldb-commits mailing list