[Lldb-commits] [lldb] r254602 - Fix TestLoadUnload for Windows -> POSIX remote debugging

Tamas Berghammer via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 3 03:02:10 PST 2015


Author: tberghammer
Date: Thu Dec  3 05:02:10 2015
New Revision: 254602

URL: http://llvm.org/viewvc/llvm-project?rev=254602&view=rev
Log:
Fix TestLoadUnload for Windows -> POSIX remote debugging

Previously we used sys.os.path for appending target pathes what failed
when cased dlopen to fail on the target because of the '\'.

The fix won't work for local Windows tests but dlopen don't available
on Windows anyway so the test don't make sense in that context.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py?rev=254602&r1=254601&r2=254602&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py Thu Dec  3 05:02:10 2015
@@ -211,7 +211,8 @@ class LoadUnloadTestCase(TestBase):
             dylibName = 'libloadunload_a.so'
 
         if lldb.remote_platform:
-            dylibPath = os.path.join(shlib_dir, dylibName)
+            # Don't use os.path.join as we have to use the path separator for the target
+            dylibPath = shlib_dir + '/' + dylibName
         else:
             dylibPath = dylibName
 




More information about the lldb-commits mailing list