[Lldb-commits] [PATCH] D15046: Fix for TestNoreturnUnwind.py on i386

[Jason Molenda via lldb-commits]

jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda added a comment.

Hi Ravitheja, thanks for the logging output.  It does look like the assembly profiling is failing for some reason, and with your patch we fall back to using the eh_frame instructions and it succeeds.  I'll look at the patch closely tomorrow (I meant to do it tonight but I'm running out of time before I need to head home) - but I'm just curious what lldb will report for

(lldb) image show-unwind -n __kernel_vsyscall

when you have the process running.  Looking at the assembly instructions, it seems like the assembly language profile inspection should have done the right thing here.  The rule "CFA=ebp+16 => ebp=[CFA-16] esp=CFA+0 eip=[CFA-4]" looks right to me at this point in the function.

Thanks!

Jason


http://reviews.llvm.org/D15046