[Lldb-commits] [PATCH] D15042: PTRACE ABI to read FXSAVE area for 32-bit inferior

Tamas Berghammer via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 1 05:26:36 PST 2015


tberghammer added inline comments.

================
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:853-854
@@ +852,4 @@
+            {
+                if (log)
+                    log->Printf("NativeRegisterContextLinux_x86_64::%s ptrace APIs failed to read XSAVE/FXSAVE area", __FUNCTION__);
+            }
----------------
Adding a log message is a good idea but please include the error message from ReadFPR in the log message. It will usually contain the error message returned by the ptrace call.


http://reviews.llvm.org/D15042





More information about the lldb-commits mailing list