[Lldb-commits] [PATCH] D15092: Fix hang in global static initialization
Adrian McCarthy via lldb-commits
lldb-commits at lists.llvm.org
Mon Nov 30 14:14:04 PST 2015
amccarth added inline comments.
Comment at: source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:185
@@ -184,3 +184,3 @@
- static const ConstString FallbackStructName; // Print this as the type name of a struct Element
// If we can't resolve the actual struct name
> I wonder about returning this by reference. It seems like by convention we usually pass `ConstString`s around by value.
I was following the pattern used elsewhere, like Breakpoint::BreakpointEventData::GetFlavorString.
More information about the lldb-commits