[Lldb-commits] [PATCH] D15092: Fix hang in global static initialization

[Adrian McCarthy via lldb-commits]

amccarth added inline comments.

================
Comment at: source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:185
@@ -184,3 +184,3 @@
 
-    static const ConstString FallbackStructName;         // Print this as the type name of a struct Element
                                                          // If we can't resolve the actual struct name
----------------
zturner wrote:
> I wonder about returning this by reference.  It seems like by convention we usually pass `ConstString`s around by value.
I was following the pattern used elsewhere, like Breakpoint::BreakpointEventData::GetFlavorString.


http://reviews.llvm.org/D15092