[Lldb-commits] [PATCH] D15067: Design building out of sources

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 30 08:57:21 PST 2015


labath added a comment.

Hmm.. you are right, of course.. I was only looking at the second version of the patch, which seems to omit the regex files. However that seems to by accidental, as they are still references in the CMake files.

I agree that we should not copy the files over.

@krytarowski, I assume that the problem is that the regex headers are in llvm/lib (instead of include/llvm), which means they are not installed, and you cannot include them later. Is that correct?

It seems that is being done on purpose, so I guess it's a question whether lldb-mi should have been using them in the first place. We'll need to think about this more.


Repository:
  rL LLVM

http://reviews.llvm.org/D15067





More information about the lldb-commits mailing list