[Lldb-commits] [PATCH] D15065: Define new builder_netbsd

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Sun Nov 29 20:02:46 PST 2015


Ok, if there's already precedent for duplicating the files then go ahead
and follow the pattern.  Although I'm not sure I'm crazy about duplicating
files on the off chance that something might be different someday.

In any case, lgtm.

On Sun, Nov 29, 2015 at 8:01 PM Kamil Rytarowski <n54 at gmx.com> wrote:

> krytarowski added a comment.
>
> In http://reviews.llvm.org/D15065#298279, @zturner wrote:
>
> > This doesn't look substantially different than builder_freebsd.  Assuming
> >  there is no practical difference, how about just using that for both
> >  freebsd and netbsd?
>
>
> The linux2, win32 and freebsd targets have the files with the same
> content. I dislike the idea to share it only between FreeBSD and NetBSD.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D15065
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151130/970380e6/attachment.html>


More information about the lldb-commits mailing list