[Lldb-commits] [PATCH] D15042: PTRACE ABI to read FXSAVE area for 32-bit inferior

[Tamas Berghammer via lldb-commits]

tberghammer added inline comments.

================
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:849-850
@@ -844,2 +848,4 @@
             m_fpr_type = eFPRTypeFXSAVE;
+            assert (const_cast<NativeRegisterContextLinux_x86_64*>(this)->ReadFPR().Success() &&
+                    "ptrace APIs to read either XSAVE or FXSAVE area didn't work.");
         }
----------------
I think we don't want this assert because of 2 reason:
* If we are running on a machine where we can't access to any floating point registers then this assert will fire but lldb is still functional in that case
* It is changing the internal state of the object so it will cause a different behavior in debug and in release builds what we should avoid as it can cause hard to diagnose issues


http://reviews.llvm.org/D15042