[Lldb-commits] [PATCH] D15019: [LLGS] Don't forward I/O when process is stopped

Tamas Berghammer via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 26 08:21:48 PST 2015


tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1014
@@ +1013,3 @@
+
+    Error error;
+    m_stdio_handle_up = m_mainloop.RegisterReadObject(
----------------
Can you add an assert that m_stdio_handle_up is nullptr when StartSTDIOForwarding is called?


http://reviews.llvm.org/D15019





More information about the lldb-commits mailing list