[Lldb-commits] [PATCH] D14860: [LLDB][MIPS] Getting 0 index for h/w watchpoint is not necessarily an error

Mohit Bhakkad via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 23 04:22:49 PST 2015


This revision was automatically updated to reflect the committed changes.
Closed by commit rL253864: [LLDB][MIPS] Getting 0 index for H/W watchpoint is not necessarily an error (authored by mohit.bhakkad).

Changed prior to commit:
  http://reviews.llvm.org/D14860?vs=40744&id=40913#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D14860

Files:
  lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp

Index: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
===================================================================
--- lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
+++ lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
@@ -1092,7 +1092,7 @@
             }
         }
     }
-    return 0;
+    return LLDB_INVALID_INDEX32;
 }
 
 bool
@@ -1221,7 +1221,7 @@
     int index = GetVacantWatchIndex (&regs, addr, size, watch_flags, NumSupportedHardwareWatchpoints());
 
     // New watchpoint doesn't fit
-    if (!index)
+    if (index == LLDB_INVALID_INDEX32)
     return LLDB_INVALID_INDEX32;
 
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14860.40913.patch
Type: text/x-patch
Size: 692 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151123/e6440962/attachment-0001.bin>


More information about the lldb-commits mailing list