[Lldb-commits] [PATCH] D14895: Prevent ProcessGDBRemote from launching local debug server in case of remote debug server connection failure

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 23 01:48:10 PST 2015

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Nice catch. Looks good.

Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3516
@@ -3544,1 +3515,3 @@
+ProcessGDBRemote::CheckDebugserverConnection (const ProcessInfo &process_info)
I find this name somewhat misleading. `Check` would generally imply a read-only operation, but this actually establishes the connection in some circumstances. I'd go for `EstablishConnectionIfNeeded` or something like that.


More information about the lldb-commits mailing list