[Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

[Adrian McCarthy via lldb-commits]

amccarth marked an inline comment as done.

================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:159
@@ +158,3 @@
+{
+    return SaveMiniDump(process_sp, outfile, error);
+}
----------------
clayborg wrote:
> I would rather just have the code from SaveMiniDump inlined in this file, no need for a new file just for one function.
I would prefer that too, but it's not possible.

This implementation depends on Windows headers which create conflicts with identifiers used in the main file.  (I had a note about that somewhere.  If I can't find it, I'll add a comment explanining that.)

================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFMiniDump.cpp:53-55
@@ +52,4 @@
+    return false;
+}
+
+}  // namesapce lldb_private
----------------
clayborg wrote:
> Remove this file and inline the code into ObjectFilePECOFF::SaveCore().
Can't do, as explained.

================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFMiniDump.h:1-24
@@ +1,24 @@
+//===-- ObjectFilePECOFFMiniDump.h ------------------------------*- C++ -*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef liblldb_ObjectFilePECOFFMiniDump_h_
+#define liblldb_ObjectFilePECOFFMiniDump_h_
+
+#include "lldb/Target/Process.h"
+
+namespace lldb_private {
+
+bool
+SaveMiniDump(const lldb::ProcessSP &process_sp,
+             const lldb_private::FileSpec &outfile,
+             lldb_private::Error &error);
+
+}  // namespace lldb_private
+
+#endif
----------------
clayborg wrote:
> Remove this file and inline the code into ObjectFilePECOFF::SaveCore().
Can't do as explained in previous response.


http://reviews.llvm.org/D14793