[Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

[Zachary Turner via lldb-commits]

zturner added a comment.

It's not that I don't like it.  I mean, it used to be, but it's a minor change.  At this point it's about that I've repeatedly asked for some kind of reasonable explanation about why swig is a contentious dependency, and the most I've gotten is "things are about to change".  I don't even know what that means, and plus it sounded like it was a statement about OSX.  But now all of a sudden it's abotu Linux too.  What do I make of that?

It's not that I don't like the change, it's that I don't want to add complexity to the build system for something that I simply do not understand the value of.  Installing swig is one command line on Linux, and one or two command lines on OSX.  So why do we need to add 15 lines of CMake code so that people don't have to do a one-time execution of one or two command lines the first time they ever check out and try to build LLDB?

That's what I don't get.  Maybe there's a reason, if so I'll LGTM it in a heartbeat, because it is a simple change.  But if so it hasn't been clearly communicated.


http://reviews.llvm.org/D14790