[Lldb-commits] [lldb] r253488 - Support unix-abstract-connect scheme as platform url in lldb testsuite
Ying Chen via lldb-commits
lldb-commits at lists.llvm.org
Wed Nov 18 11:03:20 PST 2015
Author: chying
Date: Wed Nov 18 13:03:20 2015
New Revision: 253488
URL: http://llvm.org/viewvc/llvm-project?rev=253488&view=rev
Log:
Support unix-abstract-connect scheme as platform url in lldb testsuite
Reviewers: ovyalov
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D14765
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=253488&r1=253487&r2=253488&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Wed Nov 18 13:03:20 2015
@@ -461,8 +461,11 @@ def android_device_api():
assert lldb.platform_url is not None
device_id = None
parsed_url = urlparse.urlparse(lldb.platform_url)
- if parsed_url.scheme == "adb":
- device_id = parsed_url.netloc.split(":")[0]
+ host_name = parsed_url.netloc.split(":")[0]
+ if host_name != 'localhost':
+ device_id = host_name
+ if device_id.startswith('[') and device_id.endswith(']'):
+ device_id = device_id[1:-1]
retcode, stdout, stderr = run_adb_command(
["shell", "getprop", "ro.build.version.sdk"], device_id)
if retcode == 0:
Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py?rev=253488&r1=253487&r2=253488&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py Wed Nov 18 13:03:20 2015
@@ -61,8 +61,12 @@ class GdbRemoteTestCaseBase(TestBase):
self.named_pipe_fd = None
self.stub_sends_two_stop_notifications_on_kill = False
if lldb.platform_url:
- scheme, host = re.match('(.+)://(.+):\d+', lldb.platform_url).groups()
- if scheme == 'adb':
+ if lldb.platform_url.startswith('unix-'):
+ url_pattern = '(.+)://\[?(.+?)\]?/.*'
+ else:
+ url_pattern = '(.+)://(.+):\d+'
+ scheme, host = re.match(url_pattern, lldb.platform_url).groups()
+ if lldb.remote_platform_name == 'remote-android' and host != 'localhost':
self.stub_device = host
self.stub_hostname = 'localhost'
else:
More information about the lldb-commits
mailing list