[Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106
Ying Chen via lldb-commits
lldb-commits at lists.llvm.org
Fri Nov 13 19:24:10 PST 2015
chying added a comment.
In http://reviews.llvm.org/D14673#289408, @zturner wrote:
> I guess this is ok. I don't like raising the `None` check outside the function, but I don't see another way that isn't more convoluted.
> However, I think you still need to fix the grouping of the parentheses. the `compiler is None` should not override the version check.
I thought a call of expectedFailureAll(..compiler=None, compiler_version=['>=', '3.7']...) doesn't make much sense at the first place, so maybe just ignore compiler check in such cases?
Do you suggest to check current compiler(no matter clang or gcc or others) version against given version?
More information about the lldb-commits