[Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Fri Nov 13 19:06:55 PST 2015
zturner added a subscriber: zturner.
zturner added a comment.
I think the `is None` check should go back inside the `check_list_or_lambda` function. Bringing it outside the function looks identical to me. If `None` is passed to the function, the `callable()` check will fail, and then the `else` branch will return true.
Also the compiler check is wrong currently because of the grouping of parentheses. For example, if someone passes `compiler=None` and `compiler_version=3.7`, then check would succeed no matter what the compiler version was.
More information about the lldb-commits