[Lldb-commits] [lldb] r252980 - Revert "Another little stepping optimization: if any of the source step commands are running through a range "

Ying Chen via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 12 16:31:22 PST 2015


Author: chying
Date: Thu Nov 12 18:31:21 2015
New Revision: 252980

URL: http://llvm.org/viewvc/llvm-project?rev=252980&view=rev
Log:
Revert "Another little stepping optimization: if any of the source step commands are running through a range "

- Revert because this commit introduce several failures in lldb test suite
- http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8391
- This reverts commit 78943bb678c2893703ee4e8b41969372740c8a6f.

Modified:
    lldb/trunk/source/Target/ThreadPlanStepRange.cpp

Modified: lldb/trunk/source/Target/ThreadPlanStepRange.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanStepRange.cpp?rev=252980&r1=252979&r2=252980&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanStepRange.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanStepRange.cpp Thu Nov 12 18:31:21 2015
@@ -390,19 +390,12 @@ ThreadPlanStepRange::SetNextBranchBreakp
         if (branch_index == UINT32_MAX)
         {
             branch_index = instructions->GetSize() - 1;
-            InstructionSP last_inst = instructions->GetInstructionAtIndex(branch_index);
-            size_t last_inst_size = last_inst->GetOpcode().GetByteSize();
-            run_to_address = last_inst->GetAddress();
-            run_to_address.Slide(last_inst_size);
-        }
-        else if (branch_index - pc_index > 1)
-        {
-            run_to_address = instructions->GetInstructionAtIndex(branch_index)->GetAddress();
         }
         
-        if (run_to_address.IsValid())
+        if (branch_index - pc_index > 1)
         {
             const bool is_internal = true;
+            run_to_address = instructions->GetInstructionAtIndex(branch_index)->GetAddress();
             m_next_branch_bp_sp = GetTarget().CreateBreakpoint(run_to_address, is_internal, false);
             if (m_next_branch_bp_sp)
             {




More information about the lldb-commits mailing list