[Lldb-commits] [PATCH] D14555: Create PythonCallable and PythonTuple wrappers with appropriate unit tests

[Eugene Zelenko via lldb-commits]

Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.

Please also run Clang-tidy modernize checks.


================
Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:895
@@ +894,3 @@
+
+
+void
----------------
Unnecessary line.

================
Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:300
@@ -297,2 +299,3 @@
 public:
+    PythonList() {}
     explicit PythonList(PyInitialValue value);
----------------
Should be PythonList() = default; Same for other similar default constructors.

================
Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:337
@@ +336,3 @@
+
+    ~PythonTuple() override;
+
----------------
Should be ~PythonTuple() override = default; Same for PythonCallable.


http://reviews.llvm.org/D14555