[Lldb-commits] [lldb] r252325 - Make Windows always use multiprocessing-pool.

[Zachary Turner via lldb-commits]

Author: zturner
Date: Fri Nov  6 12:14:31 2015
New Revision: 252325

URL: http://llvm.org/viewvc/llvm-project?rev=252325&view=rev
Log:
Make Windows always use multiprocessing-pool.

We still see "Too many file handles" errors on Windows even with
lower numbers of cores.  It's not clear what the right balance is,
and the bar seems to move as more tests get added.  So just use
the strategy that works until we can investigate more deeply.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/dosep.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/dosep.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dosep.py?rev=252325&r1=252324&r2=252325&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/dosep.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dosep.py Fri Nov  6 12:14:31 2015
@@ -1264,11 +1264,10 @@ def default_test_runner_name(num_threads
     elif os.name == "nt":
         # On Windows, Python uses CRT with a low limit on the number of open
         # files.  If you have a lot of cores, the threading-pool runner will
-        # often fail because it exceeds that limit.
-        if num_threads > 32:
-            test_runner_name = "multiprocessing-pool"
-        else:
-            test_runner_name = "threading-pool"
+        # often fail because it exceeds that limit.  It's not clear what the
+        # right balance is, so until we can investigate it more deeply,
+        # just use the one that works
+        test_runner_name = "multiprocessing-pool"
     elif is_darwin_version_lower_than(
             distutils.version.StrictVersion("10.10.0")):
         # OS X versions before 10.10 appear to have an issue using