[Lldb-commits] [PATCH] D14417: Make lldb::endian::InlHostByteOrder() private.

Bruce Mitchener via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 5 20:41:18 PST 2015


brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
Herald added a subscriber: emaste.

Since this is within the lldb namespace, the compiler tries to
export a symbol for it. Unfortunately, since it is inlined, the
symbol is hidden and this results in a mess of warnings when
building on OS X with cmake.

Moving it to the lldb_private namespace eliminates that problem.

http://reviews.llvm.org/D14417

Files:
  include/lldb/Core/Opcode.h
  include/lldb/Core/RegisterValue.h
  include/lldb/Host/Endian.h
  source/Core/Address.cpp
  source/Core/DataEncoder.cpp
  source/Core/DataExtractor.cpp
  source/Core/Event.cpp
  source/Core/Opcode.cpp
  source/Core/Scalar.cpp
  source/Core/Stream.cpp
  source/Core/Value.cpp
  source/Core/ValueObjectConstResultImpl.cpp
  source/Expression/IRInterpreter.cpp
  source/Host/freebsd/Host.cpp
  source/Host/macosx/Host.mm
  source/Host/netbsd/Host.cpp
  source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
  source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
  source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
  source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
  source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
  source/Plugins/Process/Utility/RegisterContextDarwin_arm64.cpp
  source/Plugins/Process/Utility/RegisterContextDarwin_x86_64.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Target/ExecutionContext.cpp
  source/Target/RegisterContext.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14417.39473.patch
Type: text/x-patch
Size: 41774 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151106/d3b0caa2/attachment-0001.bin>


More information about the lldb-commits mailing list