[Lldb-commits] [PATCH] D14389: Completely avoid building Apple simulator on non-Darwin platforms.

[Zachary Turner via lldb-commits]

zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

I find the code to be a fair bit harder to understand as a result, but I guess it's not the end of the world.

Searching the source of LLVM's CMake infrastructure, this variable exists solely to make LLVM not complain about missing files in the current directory, so I can't see any way that anything outside of the current directory's CMakeList.txt could have modified it intentionally.  So I think it's safe, in the same way that the pattern for setting library dependencies is to write something like this:

  set(LLVM_LINK_COMPONENTS
    Analysis
    AsmParser
    Core
    Support
    )

rather than appending.  Anyway, up to you.


http://reviews.llvm.org/D14389