[Lldb-commits] [PATCH] D14375: [swig] Start of pylint on python build scripts.

[Bruce Mitchener via lldb-commits]

brucem added inline comments.

================
Comment at: scripts/Python/buildSwigPython.py:293
@@ +292,3 @@
+#          LLDBWrapPython.cpp file.
+# Args:    vDictArg - (R) Program input parameters.
+#          vstrSwigOpFileNamePath - (R) LLDBWrapPython.cpp file.
----------------
I shouldn't have chopped an 's' from here.

================
Comment at: scripts/Python/buildSwigPython.py:655
@@ -654,3 @@
-	strMsg = "";
-	strErrMsgProgFail = "";
-	
----------------
This was removed as it was overwriting the value of the global instead of just appending to it below.

================
Comment at: scripts/utilsDebug.py:14
@@ -16,2 +13,3 @@
 # Python modules:
+import sys
 
----------------
zturner wrote:
> What's causing modules to be added / removed from the diffed version?  Is this some kind of "include what you use" type of thing that detects if you have unused modules?
> 
> Speaking of which, this module got *added* not removed.  How was it even working before?
There was a warning at the usage of sys that it wasn't defined.

It is only used in one place in this file and that's an error path that probably never ever triggers.


http://reviews.llvm.org/D14375