[Lldb-commits] [PATCH] D14197: Handle the options and parameters separator in every MI command

[Hafiz Abid Qadeer via lldb-commits]

abidh added inline comments.

================
Comment at: tools/lldb-mi/MICmdBase.cpp:102
@@ -99,2 +101,3 @@
     m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame, m_FrameArgMandatory, true, CMICmdArgValListBase::eArgValType_Number, 1));
+    m_setCmdArgs.Add(new CMICmdArgValConsume(m_constStrArgConsume, false));
 }
----------------
ki.stfu wrote:
> The -data-disassemble command has '--' mandatory argument, but now it's always optional argument. Should it use m_ConsumeArgMandatory as it works for --thread/--frame etc?
I changed this intentionally because "--" should not be mandatory. The MI specifications does not make it mandatory and in GDB, disassemble command works with and without it. So this change bring the same behavior in lldb-mi.

================
Comment at: tools/lldb-mi/MICmdCmdData.cpp:280
@@ -279,3 +278,2 @@
         new CMICmdArgValOptionShort(m_constStrArgAddrEnd, true, true, CMICmdArgValListBase::eArgValType_StringQuotedNumber, 1));
-    m_setCmdArgs.Add(new CMICmdArgValConsume(m_constStrArgConsume, true));
     m_setCmdArgs.Add(new CMICmdArgValNumber(m_constStrArgMode, true, true));
----------------
ki.stfu wrote:
> Please expand MiDataTestCase.test_lldbmi_data_disassemble test to check that it still gives an error without '--' argument.
I have added a test that check the -data-disassemble without "--" as it is not mandatory.


http://reviews.llvm.org/D14197