[Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

[Kamil Rytarowski via lldb-commits]

krytarowski added inline comments.

================
Comment at: tools/lldb/source/Host/posix/PipePosix.cpp:43
@@ -40,3 +42,3 @@
 // TODO: Add more platforms that support pipe2.
-#if defined(__linux__) || (defined(__FreeBSD__) && __FreeBSD__ >= 10) || defined(__NetBSD__)
+#if (defined(__linux__) && LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,27)) || (defined(__FreeBSD__) && __FreeBSD__ >= 10) || defined(__NetBSD__)
 #define PIPE2_SUPPORTED 1
----------------
How about moving `PIPE2_SUPPORTED` to `include/lldb/Host/*/Config.h`? It could be renamed to `LLDB_CONFIG_PIPE2_SUPPORTED`. Feel free to include in the Linux configuration headers needed to detect Linux version.


Repository:
  rL LLVM

http://reviews.llvm.org/D14182