[Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

[Pavel Labath via lldb-commits]

labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

Thanks for the patch. Looks good, but we need to make sure things continue to work on non-linux systems...


================
Comment at: tools/lldb/source/Host/common/File.cpp:301
@@ -299,1 +300,3 @@
+    
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23)
     if (options & eOpenOptionCloseOnExec)
----------------
This needs to evaluate to true on non-linux systems.
Would `#ifdef O_CLOEXEC` work for you ?


Repository:
  rL LLVM

http://reviews.llvm.org/D14182