[Lldb-commits] [PATCH] D14162: Create Python library `seven` in lldbsuite.support

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 28 20:37:48 PDT 2015

tfiala added a comment.

Just one question on the python 3 return code for non-exceptional exit.

Comment at: packages/Python/lldbsuite/support/seven.py:12
@@ +11,3 @@
+            import subprocess
+            return (0, subprocess.check_output(command, shell=True))
+        except subprocess.CalledProcessError as e:
Is it correct to assume a 0 return code here?  Couldn't we have output and have a non-zero status return that ins't a call exception?


More information about the lldb-commits mailing list