[Lldb-commits] [PATCH] D14136: Refactor Windows process plugin to enable sharing of code between live and post-mortem debugging

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 28 09:34:14 PDT 2015

zturner added inline comments.

Comment at: source/Plugins/Process/Windows/Common/ProcessWindowsForward.h:20
@@ +19,1 @@
\ No newline at end of file

Put a newline here

Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.h:22
@@ -21,3 +21,3 @@
 class ProcessWinMiniDump : public lldb_private::Process
I was expecting this to also derive from `ProcessWindows`, because I thought that was the whole point of moving `ProcessWindows` to common and then making `ProcessWindowsLive` inherit from it.  Is there goign to be some work on this in a followup patch or did I misunderstand the purpose of raising that up to the common area?


More information about the lldb-commits mailing list