[Lldb-commits] [PATCH] D14126: Make lldb-gdbserver to take explicit socket scheme as command line argument

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 27 12:37:09 PDT 2015


clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Need to make a copy of socket_scheme in GDBRemoteCommunicationServerPlatform (save it to a std::string).


================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.h:71
@@ -69,2 +70,3 @@
     const Socket::SocketProtocol m_socket_protocol;
+    const char* m_socket_scheme;  // not owned.
     Mutex m_spawned_pids_mutex;
----------------
We should make a copy in a std::string here.


http://reviews.llvm.org/D14126





More information about the lldb-commits mailing list