[Lldb-commits] [PATCH] D14118: Changes for Bug 17384

[Tamas Berghammer via lldb-commits]

tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.

Looks good with a few minor suggestions inline


================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:578-579
@@ +577,4 @@
+    }
+
+    return;
+}
----------------
(nit): It isn't needed

================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h:91-95
@@ -90,1 +90,7 @@
 
+    /// Contains AT_SYSINFO_EHDR, which means a vDSO has been
+    /// mapped to the address space
+    bool m_contains_vdso;
+
+    lldb::addr_t m_vdso_base;
+
----------------
I would suggest to merge these 2 with setting m_vdso_base to LLDB_INVALID_ADDRESS if we don't have a vdso


http://reviews.llvm.org/D14118